| 1 | $Id: History,v 1.105 2008/07/07 10:43:04 gcosmo Exp $
|
|---|
| 2 | -------------------------------------------------------------------
|
|---|
| 3 |
|
|---|
| 4 | =========================================================
|
|---|
| 5 | Geant4 - an Object-Oriented Toolkit for Simulation in HEP
|
|---|
| 6 | =========================================================
|
|---|
| 7 |
|
|---|
| 8 | Sub-Category History file
|
|---|
| 9 | -------------------------
|
|---|
| 10 | This file should be used by G4 developers and category coordinators
|
|---|
| 11 | to briefly summarize all major modifications introduced in the code
|
|---|
| 12 | and keep track of all directory-tags.
|
|---|
| 13 | It DOES NOT substitute the CVS log-message one should put at every
|
|---|
| 14 | committal in the CVS repository !
|
|---|
| 15 |
|
|---|
| 16 | ----------------------------------------------------------
|
|---|
| 17 | * Reverse chronological order (last date on top), please *
|
|---|
| 18 | ----------------------------------------------------------
|
|---|
| 19 |
|
|---|
| 20 | Jul 07, 2008 V.Grichine geom-csg-V09-01-04
|
|---|
| 21 | - G4Sphere: fixed bug in DistanceToOut(p, v, ...) for normal 'fSTheta'
|
|---|
| 22 | greater than 90*deg, and use of tangent giving negative value.
|
|---|
| 23 | Completes series of corrections introduced in previous tag.
|
|---|
| 24 |
|
|---|
| 25 | Jun 23, 2008 T.Nikitina geom-csg-V09-01-03
|
|---|
| 26 | - G4Tubs: fix in DistanceToIn(p,v, ...) in case of point on surface with
|
|---|
| 27 | very small tangent direction; now returning kInfinity and no longer zero.
|
|---|
| 28 | It fixes rare observed cases of zero value returned by both DistanceToIn()
|
|---|
| 29 | and DistanceToOut(), causing stuck tracks with zero step length.
|
|---|
| 30 |
|
|---|
| 31 | Jun 20, 2008 V.Grichine
|
|---|
| 32 | - G4Sphere: fixed calculation of roots in DistanceToOut(p,v,...) for
|
|---|
| 33 | theta-conical surfaces interserctions and for sTheta<=90 degree intersection.
|
|---|
| 34 | Addresses issue reported when running PET application with optical photons
|
|---|
| 35 | about mis-computation of distance on half-sphere constructs.
|
|---|
| 36 | - Updated unit test for sphere.
|
|---|
| 37 |
|
|---|
| 38 | Apr 22, 2008 V.Grichine geom-csg-V09-01-02
|
|---|
| 39 | - G4Trap: corrections for arithmetic operations in 8-point constructor.
|
|---|
| 40 | Addressing problem report #934.
|
|---|
| 41 |
|
|---|
| 42 | Mar 13, 2008 G.Cosmo geom-csg-V09-01-01
|
|---|
| 43 | - Cleared compilation warnings in G4Sphere on gcc-4.3.0 for
|
|---|
| 44 | ambiguous use of parentheses in condition statements.
|
|---|
| 45 |
|
|---|
| 46 | Feb 20, 2008 T.Nikitina geom-csg-V09-01-00
|
|---|
| 47 | - G4Cons:
|
|---|
| 48 | o Added protection against NaN in GetPointOnSurface() in the case the
|
|---|
| 49 | check is run for Rmax1==Rmax2.
|
|---|
| 50 |
|
|---|
| 51 | Nov 23, 2007 T.Nikitina geom-csg-V09-00-02
|
|---|
| 52 | - Fixed problem of undefined side for valid surface normal in case of Phi
|
|---|
| 53 | section and direction through the center of either A G4Tubs or G4Cons shape.
|
|---|
| 54 |
|
|---|
| 55 | Oct 2, 2007 T.Nikitina geom-csg-V09-00-01
|
|---|
| 56 | - G4Torus:
|
|---|
| 57 | o Fixed bug in CalculateExtent() for case of non-rotated full-phi
|
|---|
| 58 | torus definition: added protection against negative value for sqrt()
|
|---|
| 59 | and corrected formula for 'delta'. Fixes problem of NaN detected in
|
|---|
| 60 | initialisation by CMS.
|
|---|
| 61 | o Fixed bug in SolveNumericJT(): corrected handling of complex roots,
|
|---|
| 62 | 'rootsrefined' is used only if the number of refined roots is the same
|
|---|
| 63 | as for primary roots. Addresses problem report #969.
|
|---|
| 64 |
|
|---|
| 65 | Aug 16, 2007 T.Nikitina geom-csg-V09-00-00
|
|---|
| 66 | - G4Tubs: fixed bug in DistanceToOut(p,v,..) for negative value under sqrt()
|
|---|
| 67 | for the case of point p on the surface and v tangent to the surface.
|
|---|
| 68 | Responsible for rare cases of NaN.
|
|---|
| 69 |
|
|---|
| 70 | May 18, 2007 G.Cosmo geom-csg-V08-03-01
|
|---|
| 71 | - Use kAngTolerance and kRadTolerance from G4GeometryTolerance class.
|
|---|
| 72 | - Coworks with tag "global-V08-03-03".
|
|---|
| 73 |
|
|---|
| 74 | May 16, 2007 T.Nikitina geom-csg-V08-03-00
|
|---|
| 75 | - G4Tubs: fixed bug for DistanceToOut(p,v) for phi section.
|
|---|
| 76 | Bug was causing segmentation fault in recursive_test (problem report #784).
|
|---|
| 77 | For v crossing the center of the tub DistanceToOut was always giving
|
|---|
| 78 | Radial distance and not distance in Phi.
|
|---|
| 79 | - G4Cons: fixed bug for DistanceToOut(p,v) for phi section,
|
|---|
| 80 | the same as for G4Tubs.
|
|---|
| 81 | - Updated unit tests.
|
|---|
| 82 |
|
|---|
| 83 | Oct 19, 2006 G.Cosmo geom-csg-V08-01-00
|
|---|
| 84 | - Added explicit computation for GetSurfaceArea() for all solids
|
|---|
| 85 | (by H.Dierckx).
|
|---|
| 86 | - Implemented caching mechanism for computation of surface area in
|
|---|
| 87 | G4CSGSolid, as done for the geometrical volume computation.
|
|---|
| 88 |
|
|---|
| 89 | Jun 06, 2006 V.Grichine geom-csg-V08-00-01
|
|---|
| 90 | - G4Tubs: added protection against NaNs in CalculateExtent() to avoid
|
|---|
| 91 | sqrt() of negative numbers due to round-off.
|
|---|
| 92 | - Updated unit tests testG4Sphere and testDistanceAccuracy.
|
|---|
| 93 |
|
|---|
| 94 | Jan 16, 2006 V.Grichine geom-csg-V08-00-00
|
|---|
| 95 | - G4Sphere: fixed bug in DistanceToOut() for theta intersections.
|
|---|
| 96 |
|
|---|
| 97 | Nov 20, 2005 V.Grichine geom-csg-V07-01-05
|
|---|
| 98 | - G4Torus: fixed bug in Inside(p) for phi sections.
|
|---|
| 99 | Fixes problem report #810.
|
|---|
| 100 |
|
|---|
| 101 | Nov 9, 2005 G.Cosmo geom-csg-V07-01-04
|
|---|
| 102 | - Added fake default constructor for all concrete solids and relevant
|
|---|
| 103 | utility classes, for usage of direct object persistency.
|
|---|
| 104 | - Implemented changes to support CLHEP-2.0.X for explicit usage of the
|
|---|
| 105 | CLHEP/HepGeom namespaces for CLHEP types.
|
|---|
| 106 |
|
|---|
| 107 | Oct 23, 2005 V.Grichine geom-csg-V07-01-03
|
|---|
| 108 | - G4Para: fixed bug in DistanceToOut(p,v) for the case v.x()<0.
|
|---|
| 109 | Following problem report from user posted on Hypernews (#452).
|
|---|
| 110 |
|
|---|
| 111 | Sep 5, 2005 O.Link geom-csg-V07-01-02
|
|---|
| 112 | - Moved implementation for DistanceToIn/Out() in G4Torus to make use of
|
|---|
| 113 | G4JTPolynomialSolver for precise calculation of the intersections.
|
|---|
| 114 | - Reviewed unit tests and reduced statistics.
|
|---|
| 115 |
|
|---|
| 116 | Aug 8, 2005 D.Anninos geom-csg-V07-01-01
|
|---|
| 117 | - Added GetPointOnSurface() to all solids. The method returns a random
|
|---|
| 118 | point according to a quasi-uniform distribution along the surface.
|
|---|
| 119 |
|
|---|
| 120 | Jul 25, 2005 O.Link geom-csg-V07-01-00
|
|---|
| 121 | - Fixed bug in G4Sphere::DistanceToOut(p,v):
|
|---|
| 122 | added check for intersection with double cone.
|
|---|
| 123 | - Added new unit test testDistanceAccuracy (V.Grichine).
|
|---|
| 124 |
|
|---|
| 125 | Jun 8, 2005 V.Grichine geom-csg-V07-00-09
|
|---|
| 126 | - Keep old specification for SurfaceNormal() to treat usage of the
|
|---|
| 127 | function for points not at the surface.
|
|---|
| 128 |
|
|---|
| 129 | Jun 6, 2005 V.Grichine geom-csg-V07-00-08
|
|---|
| 130 | - Correction to SurfaceNormal() for G4Cons, G4Sphere, G4Torus, G4Tubs
|
|---|
| 131 | for properly handling location on z-axis and in the frame origin.
|
|---|
| 132 | Fixed bug in G4Cons::SurfaceNormal(p) for normals returned from
|
|---|
| 133 | rmax and rmin.
|
|---|
| 134 | - Moved debug printouts for surface-normals to G4CSGDEBUG.
|
|---|
| 135 | - Cleared compilation warnings in unit tests and updates.
|
|---|
| 136 |
|
|---|
| 137 | May 27, 2005 J.Allison geom-csg-V07-00-07
|
|---|
| 138 | - Fixed polyhedron representation of G4Torus.
|
|---|
| 139 |
|
|---|
| 140 | May 26, 2005 G.Cosmo geom-csg-V07-00-06
|
|---|
| 141 | - G4Box.cc: restored call to AddSolid() and replaced old AddThis() in
|
|---|
| 142 | DescribeYourselfTo().
|
|---|
| 143 |
|
|---|
| 144 | May 11, 2005 V.Grichine geom-csg-V07-00-05
|
|---|
| 145 | - G4Para: bug fixed in SurfaceNormal(p) for x-distance, to be now in
|
|---|
| 146 | accordance with the surface selection using Inside(p).
|
|---|
| 147 | - Updated unit test testSurfaceNormal.cc.
|
|---|
| 148 |
|
|---|
| 149 | May 09, 2005 V.Grichine geom-csg-V07-00-04
|
|---|
| 150 | - Updated implementation of SurfaceNormal(p) to get consistence with
|
|---|
| 151 | Inside(p) functions for the treatment of phi/theta surfaces.
|
|---|
| 152 | They are treated now in both functions in terms of kAngTolerance.
|
|---|
| 153 | The reason is that historically SurfaceNormal(p) was using only
|
|---|
| 154 | kCarTolerance for estimation of shortest distance to a surface. Now,
|
|---|
| 155 | following the new updated specification, the surface selection is made
|
|---|
| 156 | according to Inside(p) approach (as kSurface is selected), i.e. - for
|
|---|
| 157 | phi/theta surfaces in terms of kAngTolerance.
|
|---|
| 158 |
|
|---|
| 159 | Apr 26, 2005 V.Grichine, J.Apostolakis
|
|---|
| 160 | - Simplified and revised the new implementation for SurfaceNormal(p)
|
|---|
| 161 | with edges/vertices and made becoming the default one for all solids.
|
|---|
| 162 |
|
|---|
| 163 | Apr 20, 2005 V.Grichine geom-csg-V07-00-03
|
|---|
| 164 | - G4Trap: fix in p.x() centering to sum over all vertices.
|
|---|
| 165 |
|
|---|
| 166 | Mar 23, 2005 J.Allison geom-csg-V07-00-02
|
|---|
| 167 | - Added test for Number-Of-Rotation-Steps in G4CSGSolid::GetPolyhedron().
|
|---|
| 168 | Requires tag "greps-V07-00-02".
|
|---|
| 169 |
|
|---|
| 170 | Mar 03, 2005 J.Allison geom-csg-V07-00-01
|
|---|
| 171 | - Changed AddThis() with AddSolid() for all solids in DescribeYourselfTo()
|
|---|
| 172 | implementation.
|
|---|
| 173 |
|
|---|
| 174 | Dec 02, 2004 V.Grichine geom-csg-V07-00-00
|
|---|
| 175 | - New alternative implementation of SurfaceNormal(p) with edges/vertices
|
|---|
| 176 | for G4Box, G4Para, G4Trap, G4Trd. Old implementation is still the default.
|
|---|
| 177 | Can be activated by setting G4NEW_SURF_NORMAL variable before compilation.
|
|---|
| 178 |
|
|---|
| 179 | Nov 15, 2004 V.Grichine geom-csg-V06-02-06
|
|---|
| 180 | - G4Trap: added check for X-centering for constructor by verteces.
|
|---|
| 181 | Fixes problem report #687.
|
|---|
| 182 | - New unit test for surface-normal and updated unit tests for sphere
|
|---|
| 183 | and trap.
|
|---|
| 184 |
|
|---|
| 185 | Oct 10, 2004 J.Allison geom-csg-V06-02-05
|
|---|
| 186 | - Added GetPolyhedron, a smart access function that creates a G4Polyhedron
|
|---|
| 187 | on request and stores for future access. A null pointer means "not
|
|---|
| 188 | available".
|
|---|
| 189 |
|
|---|
| 190 | Sep 22, 2004 V.Grichine geom-csg-V06-02-04
|
|---|
| 191 | - Added specific implementation of GetCubicVolume() for all CSG solids.
|
|---|
| 192 | The method compute the exact geometrical values and stores it.
|
|---|
| 193 | The value is reset each time a parameter of the solid is modified.
|
|---|
| 194 | - Moved inline methods for G4Orb to .icc file.
|
|---|
| 195 | - Added unit test testSurfaceInOut.cc.
|
|---|
| 196 |
|
|---|
| 197 | Sep 16, 2004 V.Grichine geom-csg-V06-02-03
|
|---|
| 198 | - Bug fix in G4Sphere::SurfaceNormal(p) for theta normals.
|
|---|
| 199 |
|
|---|
| 200 | Jul 28, 2004 V.Grichine geom-csg-V06-02-02
|
|---|
| 201 | - Fix in G4Cons::DistanceToIn(p,v) on fRmax surface and move in,
|
|---|
| 202 | the condition became a bit more strict && determinant >=0, i.e.
|
|---|
| 203 | intersections in addition to go in.
|
|---|
| 204 | Fixes a rare problem of dIn=dOut=0 observed in 3 events over a
|
|---|
| 205 | statistics of 10^8..
|
|---|
| 206 | - Updated unit test testSurfaceInOut.cc to consider the test-case above.
|
|---|
| 207 |
|
|---|
| 208 | Jul 16, 2004 V.Grichine geom-csg-V06-02-01
|
|---|
| 209 | - Fix in G4Sphere::DistanceToOut(p,v,...) on fRmin moving outside.
|
|---|
| 210 | The bug showed 3 events of dIn=dOut=0 for 10^7 statistics in
|
|---|
| 211 | testSurfaceInOut.
|
|---|
| 212 | - Added new unit test testSurfaceInOut.cc.
|
|---|
| 213 |
|
|---|
| 214 | Jul 02, 2004 V.Grichine geom-csg-V06-02-00
|
|---|
| 215 | - Fixes curing rare conditions of loops at boundaries for G4Orb and G4Sphere:
|
|---|
| 216 | o G4Orb.cc: bug fix in DistanceToIn(p,v) on fRmax surface allowing
|
|---|
| 217 | move near fRmax-fCarTolerance/2.
|
|---|
| 218 | o G4Sphere.cc: bug fix in DistanceToIn(p,v) on Rmax/min surface for
|
|---|
| 219 | condition of intersection with (Rmax/min-kCarTolerance) artificial
|
|---|
| 220 | surface.
|
|---|
| 221 | - Updated unit test for G4Orb.
|
|---|
| 222 |
|
|---|
| 223 | Mar 18, 2004 V.Grichine geom-csg-V06-00-01
|
|---|
| 224 | - G4Torus.cc: bug fix in Inside(p) fixing warnings reported in
|
|---|
| 225 | debug-mode of 'point p is outside'.
|
|---|
| 226 |
|
|---|
| 227 | Jan 26, 2004 V.Grichine geom-csg-V06-00-00
|
|---|
| 228 | - Converted strong exceptions in warning notifications for rare anomalous
|
|---|
| 229 | conditions in DistanceToOut(p,v,..).
|
|---|
| 230 | - G4Cons.cc: bug fix in DistanceToIn(p,v) to resolve situations of calls
|
|---|
| 231 | to DistanceToOut() for points outside.
|
|---|
| 232 |
|
|---|
| 233 | Dec 4, 2003 V.Grichine geom-csg-V05-02-06
|
|---|
| 234 | - G4Trap.cc: fixed initialisation of planes in default constructor.
|
|---|
| 235 | - Added new unit test for G4Sphere and new test case for G4Cons.
|
|---|
| 236 |
|
|---|
| 237 | Nov 5, 2003 V.Grichine geom-csg-V05-02-05
|
|---|
| 238 | - G4Orb[.hh.cc]: introduced relative tolerance accuracy on fRmax surface
|
|---|
| 239 | in all methods.
|
|---|
| 240 |
|
|---|
| 241 | Nov 3, 2003 G.Cosmo geom-csg-V05-02-04
|
|---|
| 242 | - Code cleanup and headers inclusion review
|
|---|
| 243 | (replaced by forward declarations where necessary).
|
|---|
| 244 |
|
|---|
| 245 | Nov 2, 2003 V.Grichine
|
|---|
| 246 | - G4Sphere, G4Orb: revision of algorithm for Phi sections in
|
|---|
| 247 | method Inside().
|
|---|
| 248 |
|
|---|
| 249 | Oct 29, 2003 J.Apostolakis geom-csg-V05-02-03
|
|---|
| 250 | - G4Sphere.cc: fix for in Inside() for a point with Phi angle:
|
|---|
| 251 | 0.5 kAngTol < phi < Phi_start
|
|---|
| 252 |
|
|---|
| 253 | Oct 28, 2003 G.Cosmo geom-csg-V05-02-02
|
|---|
| 254 | - Migrated to new G4Exception scheme.
|
|---|
| 255 |
|
|---|
| 256 | Oct 09, 2003 V.Grichine geom-csg-V05-02-01
|
|---|
| 257 | - Initialise safe=0.0 in DistanceToIn/Out(p) in all solids.
|
|---|
| 258 | - Introduced G4Orb solid: a simple sphere with only outer radius.
|
|---|
| 259 |
|
|---|
| 260 | Sep 30, 2003 G.Cosmo geom-csg-V05-02-00
|
|---|
| 261 | - Updated GNUmakefile for unit tests, according to new structure
|
|---|
| 262 | introduced in "geometry-V05-02-00".
|
|---|
| 263 |
|
|---|
| 264 | Jun 25, 2003 G.Folger geom-csg-V05-01-00
|
|---|
| 265 | - Added disclaimer of liability where needed.
|
|---|
| 266 |
|
|---|
| 267 | Feb 03, 2003 G.Cosmo geom-csg-V05-00-00
|
|---|
| 268 | - G4Cons.cc: enhanced treatment of phi-sections,
|
|---|
| 269 | according to algorithm used also in G4Tubs (V.Grichine).
|
|---|
| 270 | - Updated unit tests.
|
|---|
| 271 |
|
|---|
| 272 | Oct 28, 2002 G.Cosmo geom-csg-V04-01-01
|
|---|
| 273 | - Added implementation of StreamInfo() to comply with new interface for
|
|---|
| 274 | G4VSolid in "geommng-V04-01-03".
|
|---|
| 275 | - Moved inline functions to .icc files, reorganised comments for the Software
|
|---|
| 276 | Reference Manual.
|
|---|
| 277 | - Some cosmetic changes to code formatting, removed all <TAB> characters and
|
|---|
| 278 | adopted uniform code indentation.
|
|---|
| 279 | - Extended unit tests for G4Cons and G4Sphere (V.Grichine).
|
|---|
| 280 |
|
|---|
| 281 | Jun 26, 2002 V.Grichine geom-csg-V04-01-00
|
|---|
| 282 | - G4Cons.cc: bug fixed in DistanceToIn(p,v) concerning z-crossing at the
|
|---|
| 283 | edge with Rmin,Rmax.
|
|---|
| 284 |
|
|---|
| 285 | Jun 19, 2002 V.Grichine geom-csg-V04-00-05
|
|---|
| 286 | - G4Sphere.cc: bug fixed in Inside() for treatment of point p on z-axis.
|
|---|
| 287 | Added new condition [(rho2 || p.z()) && fDTheta < M_PI - kAngTolerance*0.5)]
|
|---|
| 288 | for treating special case. Fixes problem report #378.
|
|---|
| 289 |
|
|---|
| 290 | May 15, 2002 G.Cosmo geom-csg-V04-00-04
|
|---|
| 291 | - G4Trap.cc, G4Tubs.cc: changed local enum 'kUndefined' to 'kUndef',
|
|---|
| 292 | to co-work with tag "global-V04-00-06", where 'kUndefined' is now
|
|---|
| 293 | defined for EAxis.
|
|---|
| 294 |
|
|---|
| 295 | Apr 16, 2002 V.Grichine geom-csg-V04-00-03
|
|---|
| 296 | - G4Tubs.cc: restored "vertices" algorithm for CalculateExtent() which
|
|---|
| 297 | was temporarly disabled (see reference to tag geom-solids-csg-V03-00-03).
|
|---|
| 298 | - Updated unit test for G4Tubs, testG4Tubs.cc.
|
|---|
| 299 |
|
|---|
| 300 | Feb 15, 2002 V.Grichine geom-csg-V04-00-02
|
|---|
| 301 | - G4Para.cc: fixed bug in G4Para::Inside() in calculation of xt,
|
|---|
| 302 | according to problem report #357.
|
|---|
| 303 |
|
|---|
| 304 | Jan 31, 2002 V.Grichine geom-csg-V04-00-01
|
|---|
| 305 | - G4Sphere.cc: bug fix in Inside() function.
|
|---|
| 306 | Fix problem report #216.
|
|---|
| 307 | - Updated unit test for G4Sphere.
|
|---|
| 308 |
|
|---|
| 309 | Jan 10, 2002 G.Cosmo geom-solids-csg-V04-00-00
|
|---|
| 310 | - Moved all verbosity mode warnings to G4CSGDEBUG and commented exceptions.
|
|---|
| 311 | - Activated G4CSGDEBUG mechanism in GNUmakefile.
|
|---|
| 312 | - G4Sphere.cc: fixed a problem with tolerances in the case of large Radius.
|
|---|
| 313 | The case (test18) involves an Rmax = 250 000 000.00 mm
|
|---|
| 314 | The ratio -9
|
|---|
| 315 | tolerance 1.0 10 -17
|
|---|
| 316 | ----------- = ------------ = 0.4 10
|
|---|
| 317 | Rmax +8
|
|---|
| 318 | 2.5 10
|
|---|
| 319 | which is smaller than the precision of doubles.
|
|---|
| 320 | Solution (for DistanceToOut(), where problem occured):
|
|---|
| 321 | use a flexible tolerance, equal to the maximum of (kRadTolerance, 10 * R )
|
|---|
| 322 | (J.Apostolakis).
|
|---|
| 323 | - Upgraded unit tests and fixed warnings on gcc-2.95-2.
|
|---|
| 324 |
|
|---|
| 325 | Aug 27, 2001 V.Grichine geom-solids-csg-V03-02-00
|
|---|
| 326 | - G4Sphere.cc: bug fixed in G4Sphere::SurfaceNormal for the case kNETheta.
|
|---|
| 327 | Fixes problem report #290.
|
|---|
| 328 |
|
|---|
| 329 | May 18, 2001 G.Cosmo geom-solids-csg-V03-01-02
|
|---|
| 330 | - Added G4CSGDEBUG preprocessor flag to discriminate for debug verbosity
|
|---|
| 331 | specific to CSG solids. Included in G4Exception of DistanceToOut() for
|
|---|
| 332 | "point p is outside" in G4Box, G4Cons, G4Tubs.
|
|---|
| 333 |
|
|---|
| 334 | Apr 20, 2001 G.Cosmo geom-solids-csg-V03-01-01
|
|---|
| 335 | - Updates for migration to STL vector.
|
|---|
| 336 | Modified files: G4Box.cc, G4Cons.cc, G4Para.cc, G4Sphere.cc,
|
|---|
| 337 | G4Torus.cc, G4Trap.cc, G4Trd.cc, G4Tubs.cc.
|
|---|
| 338 | Require coworking with the rest of geometry-V03-01-00.
|
|---|
| 339 |
|
|---|
| 340 | Apr 18, 01 V. Grichine geom-solids-csg-V03-01-00
|
|---|
| 341 | - G4Trap.cc:
|
|---|
| 342 | o Fixed memory leak in CalculateExtent() for creation of vertices in
|
|---|
| 343 | case of finite rotation. (courtesy of D.Williams)
|
|---|
| 344 | o Removed useless inclusion of math.h.
|
|---|
| 345 |
|
|---|
| 346 | Feb 21, 01 V. Grichine geom-solids-csg-V03-00-03
|
|---|
| 347 | - G4Tubs.cc:
|
|---|
| 348 | o Fixed bug in function Inside(p) in computation of pPhi
|
|---|
| 349 | for points at phi = 0 if the (start phi)+(delta phi) is at phi = 0.
|
|---|
| 350 | o Temporarly modified CalculateExtent(...), now simply based on
|
|---|
| 351 | G4Box::CalculateExtent(...). Updated unit test testG4Tubs.cc.
|
|---|
| 352 |
|
|---|
| 353 | Feb 01, 01 V. Grichine geom-solids-csg-V03-00-02
|
|---|
| 354 | - G4Box: introduced checks against negative (or <2*kCarTolerance) dimensions
|
|---|
| 355 | in methods SetXHalfLength(), SetYHalfLength() and SetZHalfLength().
|
|---|
| 356 |
|
|---|
| 357 | Jan 29, 00 G. Cosmo geom-solids-csg-V03-00-01
|
|---|
| 358 | - G4Box: introduced fixes to algorithm for computation of rotated vertices
|
|---|
| 359 | in CalculateExtent() as previously committed in tag geom-solids-csg-V02-00-10.
|
|---|
| 360 | - G4Torus: extracted logic for G4PolynomialSolver now included in
|
|---|
| 361 | global/HEPNumerics. Coworks with tag global-V03-00-02.
|
|---|
| 362 | - Added dependency to global/HEPNumerics in GNUmakefile.
|
|---|
| 363 |
|
|---|
| 364 | Jan 18, 00 V. Grichine geom-solids-csg-V03-00-00
|
|---|
| 365 | - Fixed condition from (pPhi<0) to (pPhi<-0.5*kAngleTolerance) in
|
|---|
| 366 | G4Tubs::Inside(p). Fixes problem report #198.
|
|---|
| 367 |
|
|---|
| 368 | Dec 07, 00 V. Grichine geom-solids-csg-V02-00-14
|
|---|
| 369 | - G4Tubs.cc: corrections in phi-section algorithm of Inside(p).
|
|---|
| 370 |
|
|---|
| 371 | Dec 01, 00 G. Cosmo geom-solids-csg-V02-00-13
|
|---|
| 372 | - Increased basic number of iterations from 8 to 12 for Newton algorithm
|
|---|
| 373 | in G4Torus.cc to assure root retrivial.
|
|---|
| 374 |
|
|---|
| 375 | Nov 28, 00 V. Grichine geom-solids-csg-V02-00-12
|
|---|
| 376 | - Bug fixed in G4Tubs::Inside(p) for analysis of phi positioning when
|
|---|
| 377 | on +-fDz surface.
|
|---|
| 378 |
|
|---|
| 379 | Nov 20, 00 G. Cosmo geom-solids-csg-V02-00-11
|
|---|
| 380 | - Fixes to remove warnings from "-Wall -ansi -pedantic" g++ compiler options:
|
|---|
| 381 | o commented out variables declared and not used.
|
|---|
| 382 | o fixed declaration of variables used before being initialised.
|
|---|
| 383 | o fixed order of initialisation of member data in constructors.
|
|---|
| 384 | o fixed usage of unsigned-int (size_t) for array indeces.
|
|---|
| 385 | - NB: based on tag geom-solids-csg-V02-00-09.
|
|---|
| 386 |
|
|---|
| 387 | Nov 16, 00 V. Grichine geom-solids-csg-V02-00-10
|
|---|
| 388 | - G4Box.cc: introduced fixes to algorithm for computation of rotated vertices
|
|---|
| 389 | in CalculateExtent(). (D.Williams)
|
|---|
| 390 |
|
|---|
| 391 | Nov 10, 00 G. Cosmo geom-solids-csg-V02-00-09
|
|---|
| 392 | - G4Torus.cc: removed debug print-out which was still included by mistake
|
|---|
| 393 | in constructor.
|
|---|
| 394 |
|
|---|
| 395 | Nov 02, 00 G. Cosmo geom-solids-csg-V02-00-08
|
|---|
| 396 | - QA code revision and cleanup (+fixes from CodeWizard filtering):
|
|---|
| 397 | o Removed virtual keyword from GetEntityType() concrete function.
|
|---|
| 398 | o General cosmetics.
|
|---|
| 399 |
|
|---|
| 400 | Oct 31, 00 V. Grichine geom-solids-csg-V02-00-07
|
|---|
| 401 | - G4Tubs::DistanceToOut(p,v,...):
|
|---|
| 402 | o Initialised sr and sphi to kInfinity and re-introduced additional
|
|---|
| 403 | condition on check for Rmin intersection (t2 >= 0).
|
|---|
| 404 |
|
|---|
| 405 | Oct 26, 00 G. Cosmo geom-solids-csg-V02-00-06
|
|---|
| 406 | - G4Cons::DistanceToOut(p,v): leave out warning if point is outside.
|
|---|
| 407 |
|
|---|
| 408 | Oct 23, 00 G. Cosmo geom-solids-csg-V02-00-05
|
|---|
| 409 | - G4Tubs::DistanceToOut(p,v,...):
|
|---|
| 410 | o Still correction to thickness of conical surfaces. (V.Grichine)
|
|---|
| 411 | o Commented-out additional condition on check for Rmin intersection
|
|---|
| 412 | (t2 >= 0), recently introduced (roi2).
|
|---|
| 413 | Requires further investigation !!
|
|---|
| 414 | - G4Torus:
|
|---|
| 415 | o Introduced more stable numerical method (Newton-based) for computing
|
|---|
| 416 | roots of equations in DistanceToIn() and DistanceToOut(). (E.Medernach)
|
|---|
| 417 |
|
|---|
| 418 | Oct 18, 00 V. Grichine geom-solids-csg-V02-00-04
|
|---|
| 419 | - G4Cons.cc, G4Tubs.cc:
|
|---|
| 420 | added check against negative distance returned by DistanceToIn/DistanceToOut.
|
|---|
| 421 | - G4Cons.cc:
|
|---|
| 422 | added correction for thickness of conical surfaces, remarkable for big
|
|---|
| 423 | opening angles, in DistanceToIn/DistanceToOut functions.
|
|---|
| 424 |
|
|---|
| 425 | Oct 05, 00 V. Grichine geom-solids-csg-V02-00-03
|
|---|
| 426 | - G4Cons.cc:
|
|---|
| 427 | o fix in DistanceToIn(p,v): corrected condition on conical surface to
|
|---|
| 428 | consider a real projection of the conical surface thickness on XY
|
|---|
| 429 | plane (0.5*kCarTolerance*secRMin instead of 0.5*kCarTolerance), when
|
|---|
| 430 | dealing with cons with large opening angle.
|
|---|
| 431 | o Updated unit test testG4Cons2.cc.
|
|---|
| 432 |
|
|---|
| 433 | Aug 16, 00 V. Grichine geom-solids-csg-V02-00-02
|
|---|
| 434 | - G4Cons.cc:
|
|---|
| 435 | o fix in constructor to check if one of the Rmin is equal to 0,
|
|---|
| 436 | if so, it will be set to 1e3*kRadTolerance.
|
|---|
| 437 | o Deactivated call to G4Exception in DistanceToOut(p) if p is outside,
|
|---|
| 438 | replaced by simple warning.
|
|---|
| 439 | - G4Tubes.cc, G4Box.cc:
|
|---|
| 440 | o Deactivated call to G4Exception in DistanceToOut(p) if p is outside,
|
|---|
| 441 | replaced by simple warning.
|
|---|
| 442 |
|
|---|
| 443 | Aug 08, 00 V. Grichine geom-solids-csg-V02-00-01
|
|---|
| 444 | - G4Cons.cc, G4Tubs.cc:
|
|---|
| 445 | o fixes to DistanceToOut(p,v,...) to make roots of quadratic equations
|
|---|
| 446 | more stable.
|
|---|
| 447 | o added check if point is outside in G4Tubes::DistanceToOut(p),
|
|---|
| 448 | some code formatting.
|
|---|
| 449 |
|
|---|
| 450 | Jul 27, 00 V. Grichine geom-solids-csg-V02-00-00
|
|---|
| 451 | - G4Cons.cc:
|
|---|
| 452 | o added more diagnostics in DistanceToOut(p)
|
|---|
| 453 | o cosmetics changes
|
|---|
| 454 | - Updated unit test for G4Cons.
|
|---|
| 455 |
|
|---|
| 456 | Jun 22, 00 V. Grichine geom-solids-csg-V01-01-04
|
|---|
| 457 | - G4Box.cc:
|
|---|
| 458 | o added safety against call from outside in DistanceToOut(p)
|
|---|
| 459 | o added more diagnostics before exception in DistanceToOut(p,v,...)
|
|---|
| 460 | o cosmetics changes
|
|---|
| 461 | - G4Torus[.hh.cc]:
|
|---|
| 462 | o added new alternative functions SolveBiQuadratic/CubicNew.
|
|---|
| 463 | o fix in SolveBiQuadratic() for ambiguous expression in looping index
|
|---|
| 464 | detected by Insure++.
|
|---|
| 465 | - Updated unit tests testG4Torus and testG4Trd.
|
|---|
| 466 |
|
|---|
| 467 | May 17, 00 V. Grichine geom-solids-csg-V01-01-03
|
|---|
| 468 |
|
|---|
| 469 | - G4Tubs.cc:
|
|---|
| 470 | o introduced fix in DistanceToOut(p,v,...) in computation of xi, yi for
|
|---|
| 471 | (sphi >= -0.5*kCarTolerance). This fixes problem reports #76 and #91.
|
|---|
| 472 | o added more diagnostics in case of invalid enum for DistanceToOut.
|
|---|
| 473 | - Updated unit test for G4Tubs.
|
|---|
| 474 |
|
|---|
| 475 | May 05, 00 V. Grichine geom-solids-csg-V01-01-02
|
|---|
| 476 |
|
|---|
| 477 | - G4Box.cc, G4Trd.cc:
|
|---|
| 478 | o modified DistanceToIn(p,v) to return 0 distance in case computed
|
|---|
| 479 | value is less than 0.5*kCarTolerance.
|
|---|
| 480 | o Cosmetic changes.
|
|---|
| 481 | - Updated unit tests for G4Box and G4Trd.
|
|---|
| 482 |
|
|---|
| 483 | Apr 11, 00 J. Allison
|
|---|
| 484 |
|
|---|
| 485 | - Removed implementations of GetExtent in most sub-classes of G4VSolid (a
|
|---|
| 486 | default implementation exists in G4VSolid).
|
|---|
| 487 | - All implementations of DescribeYourselfTo (G4VGraphicsScene& scene) const
|
|---|
| 488 | now correctly written: scene.AddThis(*this).
|
|---|
| 489 |
|
|---|
| 490 | Apr 05, 00 G. Cosmo geom-solids-csg-V01-01-01
|
|---|
| 491 | - G4Tubs.cc: fixed bug in function Inside(p).
|
|---|
| 492 | Removed (commented) in the code umproper addition of 2PI
|
|---|
| 493 | to Phi-angle particle (V.Grichine)
|
|---|
| 494 | - G4Hype[.hh.cc]: fixed several longstanding issues and bring methods
|
|---|
| 495 | into compliance with specifications (D.Williams)
|
|---|
| 496 | - Moved to "specific" the following classes:
|
|---|
| 497 | G4ClippablePolygon, G4EnclosingCylinder, G4Hype, G4PolyPhiFace,
|
|---|
| 498 | G4Polycone, G4PolyconeSide, G4Polyhedra, G4PolyhedraSide,
|
|---|
| 499 | G4ReduciblePolygon, G4IntersectingCone, G4SolidExtentList,
|
|---|
| 500 | G4VCSGface, G4VCSGfaceted.
|
|---|
| 501 | - Moved testG4Hype.cc and testG4Polycone.cc from CSG/test to
|
|---|
| 502 | specific/test
|
|---|
| 503 | - Moved generic tests "SBT" and "Fred" one level up to solids/test.
|
|---|
| 504 | - Organised class description comments for the Software Reference Manual
|
|---|
| 505 | in all headers.
|
|---|
| 506 |
|
|---|
| 507 | Mar 23, 00 G. Cosmo geom-solids-csg-V01-01-00
|
|---|
| 508 | - Tagged.
|
|---|
| 509 |
|
|---|
| 510 | Mar 22, 00 D. Williams
|
|---|
| 511 | - G4PolyhedraSide.cc: fixed bug in G4PolyhedraSide::Normal(...).
|
|---|
| 512 | The method Normal(...) (used by G4VCSGfaceted::SurfaceNormal) was not
|
|---|
| 513 | filling in the argument bestDistance. This fixes a bug observed in
|
|---|
| 514 | G4Polyhedra::SurfaceNormal.
|
|---|
| 515 |
|
|---|
| 516 | Mar 14, 00 V. Grichine
|
|---|
| 517 | - Added diagnostics in G4Cons, G4Sphere and G4Torus in function
|
|---|
| 518 | DistanceToOut(p,v,...).
|
|---|
| 519 |
|
|---|
| 520 | Mar 03, 00 G. Cosmo geom-solids-csg-V01-00-05
|
|---|
| 521 | - Minor fixes to unit tests to make them up-to-date with recent
|
|---|
| 522 | development versions (already included in tag geometry-V01-00-00a).
|
|---|
| 523 | - G4PolyconeSide.cc, G4PolyhedraSide.cc: added explicit cast to G4int
|
|---|
| 524 | to avoid warnings on Linux.
|
|---|
| 525 |
|
|---|
| 526 | Jan 19, 00 G. Cosmo geom-solids-csg-01-00-04
|
|---|
| 527 | - Fixed bug in DistanceToIn(p,v). Modified files: G4Trap.cc and
|
|---|
| 528 | testG4Trap.cc. (V.Grichine)
|
|---|
| 529 | - Syncronized file versions with HEAD (essentially CVS headers changes).
|
|---|
| 530 | - Fixes for missing migration on HEAD related to some files in test/fred
|
|---|
| 531 | and test/SBT.
|
|---|
| 532 |
|
|---|
| 533 | Nov 17, 99 J. Apostolakis geom-solids-csg-01-00-03
|
|---|
| 534 | - Tagged
|
|---|
| 535 |
|
|---|
| 536 | Nov 17, 99 V. Grichine
|
|---|
| 537 | - Added initialisation to Eside "side" variable in DistanceToOut(p,v)
|
|---|
| 538 | in CSG solids --> Problem report from D.C. Williams, BaBar
|
|---|
| 539 | - A check in G4Trap Makeplane added.
|
|---|
| 540 |
|
|---|
| 541 | Nov 10, 99 J. Apostolakis geom-solids-csg-01-00-02-cand
|
|---|
| 542 | - Included David Williams' modifications to
|
|---|
| 543 | G4IntersectingCone.cc, G4PolyconeSide.cc and G4VCSGfaceted.cc
|
|---|
| 544 | and to test/SBT/SBT.cc and test/SBT/polycone.geant4
|
|---|
| 545 |
|
|---|
| 546 | Nov 10, 99 J. Apostolakis geom-solids-csg-01-00-01
|
|---|
| 547 | - Tagged
|
|---|
| 548 |
|
|---|
| 549 | May 18, 99 David Williams
|
|---|
| 550 | - Replaced 1/DBL_MAX with DBL_MIN (valid correction, seen in tests for STL)
|
|---|
| 551 | in G4PolyPhiFace.cc, G4PolyconeSide.cc and G4PolyhedraSide.cc
|
|---|
| 552 |
|
|---|
| 553 | Apr 29, 99 David Williams
|
|---|
| 554 | - G4Polyhedra and G4Polycone (and G4VCSGfaceted) modified:
|
|---|
| 555 | 1. Implemented correct copy constructors and assignment operators.
|
|---|
| 556 | 2. Fix some leaks for tracks that pass exactly through an edge.
|
|---|
| 557 | Some leaks still remain: particularly if a track passes through
|
|---|
| 558 | a corner and between the curved edges of G4Polycone.
|
|---|
| 559 | 3. G4Polyhedra argument numSide changed to G4int (from G4double)
|
|---|
| 560 |
|
|---|
| 561 | Apr 13, 99 Vladimir Grichine and Simone Giani
|
|---|
| 562 | - Minor consistency fix to 8 basic CSG solids:
|
|---|
| 563 | Tolerance used in calculation of extent but not in one place,
|
|---|
| 564 | and not another - this tripped up the client code.
|
|---|
| 565 |
|
|---|
| 566 | Feb 16, 99 David Williams
|
|---|
| 567 | - Repaired bugs in G4Polycone (G4PolyconeSide.cc) as found in
|
|---|
| 568 | test/testG4Polycone and missed in below.
|
|---|
| 569 | - Updated definition of DistanceToIn(p) and DistanceToOut(p) to
|
|---|
| 570 | return zero when the point p is on the surface of the solid.
|
|---|
| 571 |
|
|---|
| 572 | Feb 12, 99 David Williams
|
|---|
| 573 | - src/G4PolyconeSide.cc updated (revision 1.4) to fix a bug discovered by
|
|---|
| 574 | test/testG4Polycone.
|
|---|
| 575 |
|
|---|
| 576 | Feb 9, 99 David C. Williams (davidw@scipp.ucsc.edu)
|
|---|
| 577 | - I've committed new versions of the CSG Polycone and Polyhedra in the
|
|---|
| 578 | geant4 repository, including a new utility class called
|
|---|
| 579 | G4ReduciblePolygon. The new versions fix several subtle bugs which my
|
|---|
| 580 | "test3" batch geometry testing code uncovered. In addition, the new class
|
|---|
| 581 | G4ReduciblePolygon is used to run strict tests on the validity of input
|
|---|
| 582 | parameters.
|
|---|
| 583 | To fix a bug in Polyhedra, I had to back out some fancy code that
|
|---|
| 584 | allowed it to calculate intersections at a speed that was independent of
|
|---|
| 585 | the number of sides. The new version now runs at a speed proportional to
|
|---|
| 586 | the number of sides, and is thus much slower for polyhedras with many
|
|---|
| 587 | sides. I can fix this, but I thought it would be best to get the bug fixes
|
|---|
| 588 | in as soon as possible.
|
|---|
| 589 |
|
|---|
| 590 | Feb 10, 99 John Apostolakis
|
|---|
| 591 | - History file created.
|
|---|