| [819] | 1 | -------------------------------------------------------------------
|
|---|
| 2 |
|
|---|
| 3 | ==========================================================
|
|---|
| 4 | Geant4 - an Object-Oriented Toolkit for Physics Simulation
|
|---|
| 5 | ==========================================================
|
|---|
| [1347] | 6 | $Id: History,v 1.37 2010/11/17 20:19:09 kaitanie Exp $
|
|---|
| [819] | 7 | ---------------------------------------------------------------------
|
|---|
| 8 |
|
|---|
| 9 | History file for the Liege cascade INCL Model
|
|---|
| 10 | ---------------------------------------------
|
|---|
| 11 |
|
|---|
| 12 | This file should be used to summarize modifications introduced in the
|
|---|
| 13 | code and to keep track of all tags.
|
|---|
| 14 |
|
|---|
| 15 | ---------------------------------------------------------------
|
|---|
| 16 | * Please list in reverse chronological order (last date on top)
|
|---|
| 17 | ---------------------------------------------------------------
|
|---|
| 18 |
|
|---|
| [1347] | 19 | 17 November 2010 - Pekka Kaitaniemi (hadr-incl-V09-03-10)
|
|---|
| 20 | ---------------------------------------------------------
|
|---|
| 21 | - Fixed several issues reported by Coverity:
|
|---|
| 22 | o Fix: Fragment vector and Fermi break-up related emory leaks in
|
|---|
| 23 | INCL/ABLA interfaces
|
|---|
| 24 | o Initialize INCL internal variables properly
|
|---|
| 25 | o Check array boundaries in datafile reader
|
|---|
| 26 |
|
|---|
| 27 | 16 November 2010 - Gabriele Cosmo (hadr-incl-V09-03-09)
|
|---|
| 28 | -------------------------------------------------------
|
|---|
| 29 | - More minor fixes from Coverity reports...
|
|---|
| 30 |
|
|---|
| 31 | 12 November 2010 - Pekka Kaitaniemi (hadr-incl-V09-03-08)
|
|---|
| 32 | ---------------------------------------------------------
|
|---|
| 33 | - Fixed several minor variable initialization issues reported by Coverity
|
|---|
| 34 |
|
|---|
| 35 | 11 November 2010 - Pekka Kaitaniemi (hadr-incl-V09-03-07)
|
|---|
| 36 | ---------------------------------------------------------
|
|---|
| 37 | - Fixed some minor variable initialization issues reported by Coverity
|
|---|
| 38 | - Updated interfaces:
|
|---|
| 39 | o INCL + built-in ABLA de-excitation: G4InclAblaCascadeInterface and
|
|---|
| 40 | G4InclAblaLightIonInterface
|
|---|
| 41 | o INCL + PreCompound model: G4InclCascadeInterface and
|
|---|
| 42 | G4InclLightIonInterface
|
|---|
| 43 |
|
|---|
| 44 | 03 November 2010 - Pekka Kaitaniemi (hadr-incl-V09-03-06)
|
|---|
| 45 | ---------------------------------------------------------
|
|---|
| 46 | - Fixed insufficient array index safeguard in ABLA
|
|---|
| 47 | - Silenced debugging output printed by G4InclAblaCascadeInterface
|
|---|
| 48 |
|
|---|
| [1340] | 49 | 29 October 2010 - Gunter Folger (hadr-incl-V09-03-05)
|
|---|
| [1347] | 50 | -----------------------------------------------------
|
|---|
| [1340] | 51 | - Fixed several more compilation warnings for conversion of double to int
|
|---|
| 52 | in G4Incl.cc, G4InclAblaCascadeInterface.cc, and G4InclAblaLightIonInterface.cc.
|
|---|
| 53 |
|
|---|
| 54 | 28 October 2010 - Gabriele Cosmo (hadr-incl-V09-03-04)
|
|---|
| 55 | -----------------------------------------------------
|
|---|
| 56 | - Fixed compilation warning in G4InclDataDefs.hh for conversion of double
|
|---|
| 57 | to integer in initialization.
|
|---|
| 58 |
|
|---|
| 59 | 25 October 2010 - Pekka Kaitaniemi (hadr-incl-V09-03-03)
|
|---|
| 60 | --------------------------------------------------------
|
|---|
| 61 | - Refactored INCL input data structure to its own class G4InclInput
|
|---|
| 62 | o Made data members private
|
|---|
| 63 | o Access to input data only through accessor methods
|
|---|
| 64 | o INCL now uses integer A and Z internally as well as in the interface
|
|---|
| 65 |
|
|---|
| 66 | 14 September 2010 - Pekka Kaitaniemi (hadr-incl-V09-03-02)
|
|---|
| 67 | ----------------------------------------------------------
|
|---|
| 68 | - Migrated to integer A and Z when using G4Nucleus
|
|---|
| 69 | - Bugfixes:
|
|---|
| 70 | o Make sure we use Geant4 random number generators everywhere
|
|---|
| 71 | o Silenced some unnecessary warnings
|
|---|
| 72 | o Make sure we use INCL for all light ion projectiles up to Carbon-12
|
|---|
| 73 |
|
|---|
| 74 | 16 August 2010 - Pekka Kaitaniemi
|
|---|
| 75 | ---------------------------------
|
|---|
| 76 | - Moved the INCL input initialization to the INCL input class
|
|---|
| 77 | - Implemented inverse-kinematics treatment for ion-hydrogen collisions
|
|---|
| 78 |
|
|---|
| 79 | 01 June 2010 - Pekka Kaitaniemi
|
|---|
| 80 | -------------------------------
|
|---|
| 81 | - Improved the Fermi break-up configuration
|
|---|
| 82 |
|
|---|
| 83 | 26 February 2010 - Pekka Kaitaniemi
|
|---|
| 84 | -----------------------------------
|
|---|
| 85 | - Merged INCL light ion projectile support to the integration branch
|
|---|
| 86 | o Support infrastructure for light ions up to Carbon
|
|---|
| 87 | o Use Geant4 Fermi break-up for projectile spectators and light cascade
|
|---|
| 88 | remnants
|
|---|
| 89 |
|
|---|
| [1337] | 90 | 14 June 2010 - Gabriele Cosmo (hadr-incl-V09-03-01)
|
|---|
| 91 | ------------------------------------------------------
|
|---|
| 92 | - Added missing virtual destructor to G4AblaFissionBase,
|
|---|
| 93 | G4InclAblaVirtualData and G4InclRandomNumbers.
|
|---|
| 94 |
|
|---|
| [1315] | 95 | 27 April 2010 - Pekka Kaitaniemi (hadr-incl-V09-03-00)
|
|---|
| 96 | ------------------------------------------------------
|
|---|
| 97 | - Fix: Nuclear deformation and shell effect data reader now constructs
|
|---|
| 98 | the corresponding data tables correctly.
|
|---|
| 99 | - Added some internal logging facilities to INCL (disabled by default)
|
|---|
| 100 |
|
|---|
| [1228] | 101 | 09 December 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-08)
|
|---|
| 102 | ---------------------------------------------------------
|
|---|
| 103 | - Fix: Added a safeguard against division by zero in INCL nucleon
|
|---|
| 104 | transmission probability calculation.
|
|---|
| 105 |
|
|---|
| 106 | 08 December 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-07)
|
|---|
| 107 | ---------------------------------------------------------
|
|---|
| 108 | - Fix: Added a safeguard against division by zero in INCL
|
|---|
| 109 | initialization.
|
|---|
| 110 |
|
|---|
| 111 | 08 December 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-06)
|
|---|
| 112 | ---------------------------------------------------------
|
|---|
| 113 | - Fix: Added a safeguard to avoid (hopefully rare) negative energies
|
|---|
| 114 | of INCL output particles. This would result in an attempt to take
|
|---|
| 115 | square root of a negative number.
|
|---|
| 116 |
|
|---|
| 117 | 04 December 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-05)
|
|---|
| 118 | ---------------------------------------------------------
|
|---|
| 119 | - Fix: Corrected the G4InclAblaLightIonInterface error handling. In
|
|---|
| 120 | case INCL is unable to produce a valid cascade it will return the
|
|---|
| 121 | original projectile particle back to Geant4. Unfortunately in case
|
|---|
| 122 | of the light ion interface it returned a particle with NULL pointer
|
|---|
| 123 | to particle definition.
|
|---|
| 124 | - Added safeguards to both G4InclAblaCascadeInterface and
|
|---|
| 125 | G4InclAblaLightIonInterface to prevent returning of particles with
|
|---|
| 126 | NULL definition.
|
|---|
| 127 |
|
|---|
| 128 | 03 December 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-04)
|
|---|
| 129 | ---------------------------------------------------------
|
|---|
| 130 | - Fix: Added a safeguard against attempts to compute the logarithm of zero in
|
|---|
| 131 | INCL
|
|---|
| 132 |
|
|---|
| 133 | 02 December 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-03)
|
|---|
| 134 | ---------------------------------------------------------
|
|---|
| 135 | - Fix: Corrected datatype problem in INCL initialization
|
|---|
| 136 |
|
|---|
| 137 | 22 November 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-02)
|
|---|
| 138 | ---------------------------------------------------------
|
|---|
| 139 | - Fix: Activated Geant4 random number generator instead of the built-in one.
|
|---|
| 140 |
|
|---|
| [1196] | 141 | 18 November 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-01)
|
|---|
| 142 | ---------------------------------------------------------
|
|---|
| 143 | - Added safeguard division by zero (or negative) energy in ABLA
|
|---|
| 144 | fission fragment handling
|
|---|
| 145 | - Minor fix in the INCL particle reflection time calculation
|
|---|
| 146 |
|
|---|
| 147 | 17 October 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-00)
|
|---|
| 148 | --------------------------------------------------------
|
|---|
| 149 | - Bugfixes to INCL nuclear potential handling:
|
|---|
| 150 | The interpolation function produced discontinuous results. This was
|
|---|
| 151 | due to an array index off-by-one bug. This bugfix corrects the
|
|---|
| 152 | impact parameter distribution.
|
|---|
| 153 | - Fixed several variable initialization issues in INCL.
|
|---|
| 154 | - Fixed severalFORTRAN to C++ translation issues in INCL.
|
|---|
| 155 |
|
|---|
| [962] | 156 | 06 November 2008 - Pekka Kaitaniemi (hadr-incl-V09-01-05)
|
|---|
| 157 | ---------------------------------------------------------
|
|---|
| 158 | - Fixed GCC 4.3.2 "src/G4Incl.cc:1712: warning: array subscript is above array
|
|---|
| 159 | bounds" problem. The problem occured because array size was used as an
|
|---|
| 160 | index.
|
|---|
| 161 |
|
|---|
| 162 | 06 November 2008 - Gabriele Cosmo (hadr-incl-V09-01-04)
|
|---|
| 163 | -------------------------------------------------------
|
|---|
| 164 | - Fix for compilation errors on Windows-VC++; include <time.h> in
|
|---|
| 165 | G4AblaFission and G4AblaFissionSimfis18 translation units to make them
|
|---|
| 166 | self-consistent.
|
|---|
| 167 |
|
|---|
| 168 | 24 October 2008 - Dennis Wright (hadr-incl-V09-01-03)
|
|---|
| 169 | -----------------------------------------------------
|
|---|
| 170 | - use GetNuclearMass() instead of GetAtomicMass() in G4AblaEvaporation.cc
|
|---|
| 171 |
|
|---|
| [1340] | 172 | 10 October 2008 - Pekka Kaitaniemi
|
|---|
| 173 | ------------------------------------
|
|---|
| 174 | - Added ability to use Geant4 Fermi break-up
|
|---|
| 175 | for light cascade remnants
|
|---|
| 176 |
|
|---|
| [962] | 177 | 12 September 2008 - Pekka Kaitaniemi (hadr-incl-V09-01-02)
|
|---|
| 178 | ------------------------------------
|
|---|
| 179 | - Bug fixes in INCL cascade:
|
|---|
| 180 | o Fixed target nucleus initialization for targets with A >= 0.19 and
|
|---|
| 181 | A <= 28.
|
|---|
| 182 | o Fixed target nucleus radius calculation for targets 6 <= A < 19.
|
|---|
| 183 | o Fixed conditional statements to avoid uninitialized variables.
|
|---|
| 184 | o Several array index handling (off-by-one) bugs fixed.
|
|---|
| 185 | o Several possible double/integer datatype problems fixed.
|
|---|
| 186 |
|
|---|
| 187 | 25 June 2008 - Pekka Kaitaniemi (hadr-incl-V09-01-01)
|
|---|
| 188 | ------------------------------
|
|---|
| 189 | - Portability fixes and code clean-up:
|
|---|
| 190 | o Removed all assert() calls.
|
|---|
| 191 | o Removed all isnan() and isinf() calls.
|
|---|
| 192 | o All math functions now use std:: namespace.
|
|---|
| 193 | o Silenced the fission models.
|
|---|
| 194 |
|
|---|
| 195 | 26 May 2008 - Pekka Kaitaniemi (hadr-incl-V09-01-00)
|
|---|
| 196 | ------------------------------
|
|---|
| 197 | - Bug fixes:
|
|---|
| 198 | o Fixed serious data reading bug affecting the reading of data
|
|---|
| 199 | files: flalpha.dat, frldm.dat and vgsld.dat.
|
|---|
| 200 | - Fission reorganization:
|
|---|
| 201 | o Two fission models are provided. By default GSI SimFis3 fission is
|
|---|
| 202 | used. Optional SimFis18 is provided.
|
|---|
| 203 |
|
|---|
| 204 | 22 April 2008 - Pekka Kaitaniemi
|
|---|
| 205 | -----------------------------------
|
|---|
| 206 | - INCL/ABLA changes:
|
|---|
| 207 | o Fix: Partial fix to the Alpha evaporation energies.
|
|---|
| 208 | o Fix: Neutron energies.
|
|---|
| 209 | o Fix: Moved remnant direction calculation block and added safeguards.
|
|---|
| 210 | o ABLA bugfix: switched the transformation matrix indices.
|
|---|
| 211 |
|
|---|
| 212 | 27 February 2008 - Pekka Kaitaniemi
|
|---|
| 213 | -----------------------------------
|
|---|
| 214 | - INCL/ABLA changes since Geant4 9.1:
|
|---|
| 215 | o Initialized variables to zero and improved coding style.
|
|---|
| 216 | o Variable "bet" needs to be part of G4Fiss.
|
|---|
| 217 | o Fixed a variable definition. Variable "homega" is part of "G4Fiss".
|
|---|
| 218 | o Fixed an index off-by-one bug in G4Abla.
|
|---|
| 219 | o Fix an infinite loop.
|
|---|
| 220 | o Move the stored event number to the class definition.
|
|---|
| 221 | o Added a possible (commented) fix for ABLA output off-by-one problem.
|
|---|
| 222 | o Cleaned up G4Abla::qrot comments.
|
|---|
| 223 | - Changes to the test suite since Geant4 9.1:
|
|---|
| 224 | o Added more tests.
|
|---|
| 225 | o New test system.
|
|---|
| 226 | o Compare FORTRAN and C++ results.
|
|---|
| 227 | o Preliminary GUI for running plotting scripts.
|
|---|
| 228 |
|
|---|
| [819] | 229 | 04 December 2007 - Gabriele Cosmo (hadr-incl-V09-00-09)
|
|---|
| 230 | ---------------------------------
|
|---|
| 231 | - Again commented out call to isnan() in G4Incl.cc for allow
|
|---|
| 232 | porting to platforms other than Linux....
|
|---|
| 233 |
|
|---|
| [962] | 234 | 03 December 2007 - Pekka Kaitaniemi
|
|---|
| 235 | -----------------------------------
|
|---|
| 236 | - Added bugfixes to INCL nucleon array handling. Several off-by-one
|
|---|
| 237 | bugs were fixed. These fixes help with INCL neutron energy spectra.
|
|---|
| 238 | - 4-momentum conservation problem was noticed to be mainly ABLA
|
|---|
| 239 | related.
|
|---|
| 240 | o INCL alone violates energy conservation only by less than 20 MeV.
|
|---|
| 241 | o ABLA has problems with baryon number conservation. Some produced
|
|---|
| 242 | nucleons are not given back to INCL and Geant4. This is probably the
|
|---|
| 243 | main reason for 4-momentum conservation violations.
|
|---|
| 244 | - Added 4-momentum and baryon number conservation checking code to the
|
|---|
| 245 | interfaces (behind flag DEBUGINCL).
|
|---|
| 246 |
|
|---|
| [819] | 247 | 15 November 2007 - Pekka Kaitaniemi
|
|---|
| 248 | -----------------------------------
|
|---|
| 249 | - First fix to secondary particle Pt, Px and Phi distributions.
|
|---|
| 250 | o Momentum x-component was transformed incorrectly from spherical to
|
|---|
| 251 | cartesian coordinates.
|
|---|
| 252 |
|
|---|
| 253 | 08 November 2007 - Pekka Kaitaniemi
|
|---|
| 254 | -----------------------------------
|
|---|
| 255 | - Started using G4UniformRand as a random number generator.
|
|---|
| 256 | o It is much more sophisticated generator than the original INCL one
|
|---|
| 257 | was.
|
|---|
| 258 | o This should eliminate infinite loop in test runs on 64-bit
|
|---|
| 259 | plattforms. The old generator probably was not 64-bit clean.
|
|---|
| 260 |
|
|---|
| 261 | 31 October 2007 - Gabriele Cosmo (hadr-incl-V09-00-05)
|
|---|
| 262 | --------------------------------
|
|---|
| 263 | - Again commented out calls to isnan() and isinf() in G4Abla.cc for allow
|
|---|
| 264 | porting to platforms other than Linux.
|
|---|
| 265 |
|
|---|
| 266 | 30 October 2007 - Pekka Kaitaniemi
|
|---|
| 267 | ----------------------------------
|
|---|
| 268 | - Abla now runs. Integrated energy spectrums for protons and neutrons
|
|---|
| 269 | seem to be OK. Isotope production is still problematic. There seems
|
|---|
| 270 | to be too much fission.
|
|---|
| 271 |
|
|---|
| 272 | 24 October 2007 - Pekka Kaitaniemi (hadr-incl-V09-00-04)
|
|---|
| 273 | ----------------------------------
|
|---|
| 274 | - Modified INCL to filter out unphysical events containing particles
|
|---|
| 275 | that have more energy than the energy of the projectile. This should
|
|---|
| 276 | fix problem we had with outcoming neutrons (and protons) that have
|
|---|
| 277 | more energy than the projectile particle.
|
|---|
| 278 | - Added G4InclAblaDataFile class that reads data used by INCL/ABLA
|
|---|
| 279 | from datafiles located in $G4ABLADATA. If this environment variable
|
|---|
| 280 | is not correctly set INCL/ABLA returns G4Exception.
|
|---|
| 281 | - Problematic hardcoded data has been removed.
|
|---|
| 282 |
|
|---|
| 283 | 16 October 2007 - Pekka Kaitaniemi
|
|---|
| 284 | ------------------------------------------------------
|
|---|
| 285 | - Silenced the rather verbose output. Now nothing should be printed on
|
|---|
| 286 | terminal by default.
|
|---|
| 287 | - Fixed INCL internal random number generator bug that sometimes
|
|---|
| 288 | (rarely) produced random numbers that were greater than 1.0.
|
|---|
| 289 | - Random number seeds are now taken from CLHEP::HepRandom.
|
|---|
| 290 | - Cleaned up some commented code.
|
|---|
| 291 | - Found new NaN bugs in ABLA.
|
|---|
| 292 |
|
|---|
| 293 | 13 October 2007 - Pekka Kaitaniemi
|
|---|
| 294 | ------------------------------------------------------
|
|---|
| 295 | - Interface cleanup. G4InclCascadeInterface and
|
|---|
| 296 | G4InclLightIonInterface should be fully operational.
|
|---|
| 297 | - INCL was reverted back to using simple random number generator for
|
|---|
| 298 | test result compatibility (to produce exactly same results as the
|
|---|
| 299 | FORTRAN version does).
|
|---|
| 300 | - Fixes for ABLA evaporation/fission:
|
|---|
| 301 | o Fission barrier problem fixed. Now fission code is called during
|
|---|
| 302 | the run.
|
|---|
| 303 | o Several NaN bugs fixed.
|
|---|
| 304 | o Random seed initialization bug fixed.
|
|---|
| 305 | o Stand-alone INCL/ABLA program (test/standaloneinclabla) mostly
|
|---|
| 306 | works (produces results that are sometimes in good agreement with
|
|---|
| 307 | FORTRAN version and sometimes in not so good agreement). With
|
|---|
| 308 | heavy targets and lots of energy fission is overestimated.
|
|---|
| 309 | o INCL+ABLA interface not yet fully operational. G4 simulation run
|
|---|
| 310 | crashes.
|
|---|
| 311 |
|
|---|
| 312 | 11 October 2007 - Gabriele Cosmo (hadr-incl-V09-00-01)
|
|---|
| 313 | ------------------------------------------------------
|
|---|
| 314 | - Fixes for porting:
|
|---|
| 315 | o Commented out usage of isnan() and isinf() in assertions.
|
|---|
| 316 | o Replaced usage of M_PI with CLHEP::pi.
|
|---|
| 317 | o Use std namespace for standard mathematical functions.
|
|---|
| 318 | o Casted to double arguments used in std::pow() function.
|
|---|
| 319 | o Commented out initialisation of data in G4InclAblaHardcodedData.cc
|
|---|
| 320 | for Windows; temporary solution to allow for compilation, pending
|
|---|
| 321 | solution of loading of data from file !
|
|---|
| 322 |
|
|---|
| 323 | 23 May 2007 - Aatos Heikkinen (hadr-incl-V09-00-00)
|
|---|
| 324 | ---------------------------------------------------
|
|---|
| 325 | - First version of the Liege cascade INCL Model.
|
|---|
| 326 |
|
|---|
| 327 |
|
|---|
