1 | ------------------------------------------------------------------- |
---|
2 | |
---|
3 | ========================================================== |
---|
4 | Geant4 - an Object-Oriented Toolkit for Physics Simulation |
---|
5 | ========================================================== |
---|
6 | $Id: History,v 1.26 2009/12/09 10:36:40 kaitanie Exp $ |
---|
7 | --------------------------------------------------------------------- |
---|
8 | |
---|
9 | History file for the Liege cascade INCL Model |
---|
10 | --------------------------------------------- |
---|
11 | |
---|
12 | This file should be used to summarize modifications introduced in the |
---|
13 | code and to keep track of all tags. |
---|
14 | |
---|
15 | --------------------------------------------------------------- |
---|
16 | * Please list in reverse chronological order (last date on top) |
---|
17 | --------------------------------------------------------------- |
---|
18 | |
---|
19 | 09 December 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-08) |
---|
20 | --------------------------------------------------------- |
---|
21 | - Fix: Added a safeguard against division by zero in INCL nucleon |
---|
22 | transmission probability calculation. |
---|
23 | |
---|
24 | 08 December 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-07) |
---|
25 | --------------------------------------------------------- |
---|
26 | - Fix: Added a safeguard against division by zero in INCL |
---|
27 | initialization. |
---|
28 | |
---|
29 | 08 December 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-06) |
---|
30 | --------------------------------------------------------- |
---|
31 | - Fix: Added a safeguard to avoid (hopefully rare) negative energies |
---|
32 | of INCL output particles. This would result in an attempt to take |
---|
33 | square root of a negative number. |
---|
34 | |
---|
35 | 04 December 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-05) |
---|
36 | --------------------------------------------------------- |
---|
37 | - Fix: Corrected the G4InclAblaLightIonInterface error handling. In |
---|
38 | case INCL is unable to produce a valid cascade it will return the |
---|
39 | original projectile particle back to Geant4. Unfortunately in case |
---|
40 | of the light ion interface it returned a particle with NULL pointer |
---|
41 | to particle definition. |
---|
42 | - Added safeguards to both G4InclAblaCascadeInterface and |
---|
43 | G4InclAblaLightIonInterface to prevent returning of particles with |
---|
44 | NULL definition. |
---|
45 | |
---|
46 | 03 December 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-04) |
---|
47 | --------------------------------------------------------- |
---|
48 | - Fix: Added a safeguard against attempts to compute the logarithm of zero in |
---|
49 | INCL |
---|
50 | |
---|
51 | 02 December 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-03) |
---|
52 | --------------------------------------------------------- |
---|
53 | - Fix: Corrected datatype problem in INCL initialization |
---|
54 | |
---|
55 | 22 November 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-02) |
---|
56 | --------------------------------------------------------- |
---|
57 | - Fix: Activated Geant4 random number generator instead of the built-in one. |
---|
58 | |
---|
59 | 18 November 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-01) |
---|
60 | --------------------------------------------------------- |
---|
61 | - Added safeguard division by zero (or negative) energy in ABLA |
---|
62 | fission fragment handling |
---|
63 | - Minor fix in the INCL particle reflection time calculation |
---|
64 | |
---|
65 | 17 October 2009 - Pekka Kaitaniemi (hadr-incl-V09-02-00) |
---|
66 | -------------------------------------------------------- |
---|
67 | - Bugfixes to INCL nuclear potential handling: |
---|
68 | The interpolation function produced discontinuous results. This was |
---|
69 | due to an array index off-by-one bug. This bugfix corrects the |
---|
70 | impact parameter distribution. |
---|
71 | - Fixed several variable initialization issues in INCL. |
---|
72 | - Fixed severalFORTRAN to C++ translation issues in INCL. |
---|
73 | |
---|
74 | 06 November 2008 - Pekka Kaitaniemi (hadr-incl-V09-01-05) |
---|
75 | --------------------------------------------------------- |
---|
76 | - Fixed GCC 4.3.2 "src/G4Incl.cc:1712: warning: array subscript is above array |
---|
77 | bounds" problem. The problem occured because array size was used as an |
---|
78 | index. |
---|
79 | |
---|
80 | 06 November 2008 - Gabriele Cosmo (hadr-incl-V09-01-04) |
---|
81 | ------------------------------------------------------- |
---|
82 | - Fix for compilation errors on Windows-VC++; include <time.h> in |
---|
83 | G4AblaFission and G4AblaFissionSimfis18 translation units to make them |
---|
84 | self-consistent. |
---|
85 | |
---|
86 | 24 October 2008 - Dennis Wright (hadr-incl-V09-01-03) |
---|
87 | ----------------------------------------------------- |
---|
88 | - use GetNuclearMass() instead of GetAtomicMass() in G4AblaEvaporation.cc |
---|
89 | |
---|
90 | 12 September 2008 - Pekka Kaitaniemi (hadr-incl-V09-01-02) |
---|
91 | ------------------------------------ |
---|
92 | - Bug fixes in INCL cascade: |
---|
93 | o Fixed target nucleus initialization for targets with A >= 0.19 and |
---|
94 | A <= 28. |
---|
95 | o Fixed target nucleus radius calculation for targets 6 <= A < 19. |
---|
96 | o Fixed conditional statements to avoid uninitialized variables. |
---|
97 | o Several array index handling (off-by-one) bugs fixed. |
---|
98 | o Several possible double/integer datatype problems fixed. |
---|
99 | |
---|
100 | 25 June 2008 - Pekka Kaitaniemi (hadr-incl-V09-01-01) |
---|
101 | ------------------------------ |
---|
102 | - Portability fixes and code clean-up: |
---|
103 | o Removed all assert() calls. |
---|
104 | o Removed all isnan() and isinf() calls. |
---|
105 | o All math functions now use std:: namespace. |
---|
106 | o Silenced the fission models. |
---|
107 | |
---|
108 | 26 May 2008 - Pekka Kaitaniemi (hadr-incl-V09-01-00) |
---|
109 | ------------------------------ |
---|
110 | - Bug fixes: |
---|
111 | o Fixed serious data reading bug affecting the reading of data |
---|
112 | files: flalpha.dat, frldm.dat and vgsld.dat. |
---|
113 | - Fission reorganization: |
---|
114 | o Two fission models are provided. By default GSI SimFis3 fission is |
---|
115 | used. Optional SimFis18 is provided. |
---|
116 | |
---|
117 | 22 April 2008 - Pekka Kaitaniemi |
---|
118 | ----------------------------------- |
---|
119 | - INCL/ABLA changes: |
---|
120 | o Fix: Partial fix to the Alpha evaporation energies. |
---|
121 | o Fix: Neutron energies. |
---|
122 | o Fix: Moved remnant direction calculation block and added safeguards. |
---|
123 | o ABLA bugfix: switched the transformation matrix indices. |
---|
124 | |
---|
125 | 27 February 2008 - Pekka Kaitaniemi |
---|
126 | ----------------------------------- |
---|
127 | - INCL/ABLA changes since Geant4 9.1: |
---|
128 | o Initialized variables to zero and improved coding style. |
---|
129 | o Variable "bet" needs to be part of G4Fiss. |
---|
130 | o Fixed a variable definition. Variable "homega" is part of "G4Fiss". |
---|
131 | o Fixed an index off-by-one bug in G4Abla. |
---|
132 | o Fix an infinite loop. |
---|
133 | o Move the stored event number to the class definition. |
---|
134 | o Added a possible (commented) fix for ABLA output off-by-one problem. |
---|
135 | o Cleaned up G4Abla::qrot comments. |
---|
136 | - Changes to the test suite since Geant4 9.1: |
---|
137 | o Added more tests. |
---|
138 | o New test system. |
---|
139 | o Compare FORTRAN and C++ results. |
---|
140 | o Preliminary GUI for running plotting scripts. |
---|
141 | |
---|
142 | 04 December 2007 - Gabriele Cosmo (hadr-incl-V09-00-09) |
---|
143 | --------------------------------- |
---|
144 | - Again commented out call to isnan() in G4Incl.cc for allow |
---|
145 | porting to platforms other than Linux.... |
---|
146 | |
---|
147 | 03 December 2007 - Pekka Kaitaniemi |
---|
148 | ----------------------------------- |
---|
149 | - Added bugfixes to INCL nucleon array handling. Several off-by-one |
---|
150 | bugs were fixed. These fixes help with INCL neutron energy spectra. |
---|
151 | - 4-momentum conservation problem was noticed to be mainly ABLA |
---|
152 | related. |
---|
153 | o INCL alone violates energy conservation only by less than 20 MeV. |
---|
154 | o ABLA has problems with baryon number conservation. Some produced |
---|
155 | nucleons are not given back to INCL and Geant4. This is probably the |
---|
156 | main reason for 4-momentum conservation violations. |
---|
157 | - Added 4-momentum and baryon number conservation checking code to the |
---|
158 | interfaces (behind flag DEBUGINCL). |
---|
159 | |
---|
160 | 15 November 2007 - Pekka Kaitaniemi |
---|
161 | ----------------------------------- |
---|
162 | - First fix to secondary particle Pt, Px and Phi distributions. |
---|
163 | o Momentum x-component was transformed incorrectly from spherical to |
---|
164 | cartesian coordinates. |
---|
165 | |
---|
166 | 08 November 2007 - Pekka Kaitaniemi |
---|
167 | ----------------------------------- |
---|
168 | - Started using G4UniformRand as a random number generator. |
---|
169 | o It is much more sophisticated generator than the original INCL one |
---|
170 | was. |
---|
171 | o This should eliminate infinite loop in test runs on 64-bit |
---|
172 | plattforms. The old generator probably was not 64-bit clean. |
---|
173 | |
---|
174 | 31 October 2007 - Gabriele Cosmo (hadr-incl-V09-00-05) |
---|
175 | -------------------------------- |
---|
176 | - Again commented out calls to isnan() and isinf() in G4Abla.cc for allow |
---|
177 | porting to platforms other than Linux. |
---|
178 | |
---|
179 | 30 October 2007 - Pekka Kaitaniemi |
---|
180 | ---------------------------------- |
---|
181 | - Abla now runs. Integrated energy spectrums for protons and neutrons |
---|
182 | seem to be OK. Isotope production is still problematic. There seems |
---|
183 | to be too much fission. |
---|
184 | |
---|
185 | 24 October 2007 - Pekka Kaitaniemi (hadr-incl-V09-00-04) |
---|
186 | ---------------------------------- |
---|
187 | - Modified INCL to filter out unphysical events containing particles |
---|
188 | that have more energy than the energy of the projectile. This should |
---|
189 | fix problem we had with outcoming neutrons (and protons) that have |
---|
190 | more energy than the projectile particle. |
---|
191 | - Added G4InclAblaDataFile class that reads data used by INCL/ABLA |
---|
192 | from datafiles located in $G4ABLADATA. If this environment variable |
---|
193 | is not correctly set INCL/ABLA returns G4Exception. |
---|
194 | - Problematic hardcoded data has been removed. |
---|
195 | |
---|
196 | 16 October 2007 - Pekka Kaitaniemi |
---|
197 | ------------------------------------------------------ |
---|
198 | - Silenced the rather verbose output. Now nothing should be printed on |
---|
199 | terminal by default. |
---|
200 | - Fixed INCL internal random number generator bug that sometimes |
---|
201 | (rarely) produced random numbers that were greater than 1.0. |
---|
202 | - Random number seeds are now taken from CLHEP::HepRandom. |
---|
203 | - Cleaned up some commented code. |
---|
204 | - Found new NaN bugs in ABLA. |
---|
205 | |
---|
206 | 13 October 2007 - Pekka Kaitaniemi |
---|
207 | ------------------------------------------------------ |
---|
208 | - Interface cleanup. G4InclCascadeInterface and |
---|
209 | G4InclLightIonInterface should be fully operational. |
---|
210 | - INCL was reverted back to using simple random number generator for |
---|
211 | test result compatibility (to produce exactly same results as the |
---|
212 | FORTRAN version does). |
---|
213 | - Fixes for ABLA evaporation/fission: |
---|
214 | o Fission barrier problem fixed. Now fission code is called during |
---|
215 | the run. |
---|
216 | o Several NaN bugs fixed. |
---|
217 | o Random seed initialization bug fixed. |
---|
218 | o Stand-alone INCL/ABLA program (test/standaloneinclabla) mostly |
---|
219 | works (produces results that are sometimes in good agreement with |
---|
220 | FORTRAN version and sometimes in not so good agreement). With |
---|
221 | heavy targets and lots of energy fission is overestimated. |
---|
222 | o INCL+ABLA interface not yet fully operational. G4 simulation run |
---|
223 | crashes. |
---|
224 | |
---|
225 | 11 October 2007 - Gabriele Cosmo (hadr-incl-V09-00-01) |
---|
226 | ------------------------------------------------------ |
---|
227 | - Fixes for porting: |
---|
228 | o Commented out usage of isnan() and isinf() in assertions. |
---|
229 | o Replaced usage of M_PI with CLHEP::pi. |
---|
230 | o Use std namespace for standard mathematical functions. |
---|
231 | o Casted to double arguments used in std::pow() function. |
---|
232 | o Commented out initialisation of data in G4InclAblaHardcodedData.cc |
---|
233 | for Windows; temporary solution to allow for compilation, pending |
---|
234 | solution of loading of data from file ! |
---|
235 | |
---|
236 | 23 May 2007 - Aatos Heikkinen (hadr-incl-V09-00-00) |
---|
237 | --------------------------------------------------- |
---|
238 | - First version of the Liege cascade INCL Model. |
---|
239 | |
---|
240 | |
---|