| 1 | ------------------------------------------------------------------- |
|---|
| 2 | |
|---|
| 3 | ========================================================== |
|---|
| 4 | Geant4 - an Object-Oriented Toolkit for Physics Simulation |
|---|
| 5 | ========================================================== |
|---|
| 6 | $Id: History,v 1.17 2008/11/06 10:11:27 kaitanie Exp $ |
|---|
| 7 | --------------------------------------------------------------------- |
|---|
| 8 | |
|---|
| 9 | History file for the Liege cascade INCL Model |
|---|
| 10 | --------------------------------------------- |
|---|
| 11 | |
|---|
| 12 | This file should be used to summarize modifications introduced in the |
|---|
| 13 | code and to keep track of all tags. |
|---|
| 14 | |
|---|
| 15 | --------------------------------------------------------------- |
|---|
| 16 | * Please list in reverse chronological order (last date on top) |
|---|
| 17 | --------------------------------------------------------------- |
|---|
| 18 | |
|---|
| 19 | 06 November 2008 - Pekka Kaitaniemi (hadr-incl-V09-01-05) |
|---|
| 20 | --------------------------------------------------------- |
|---|
| 21 | - Fixed GCC 4.3.2 "src/G4Incl.cc:1712: warning: array subscript is above array |
|---|
| 22 | bounds" problem. The problem occured because array size was used as an |
|---|
| 23 | index. |
|---|
| 24 | |
|---|
| 25 | 06 November 2008 - Gabriele Cosmo (hadr-incl-V09-01-04) |
|---|
| 26 | ------------------------------------------------------- |
|---|
| 27 | - Fix for compilation errors on Windows-VC++; include <time.h> in |
|---|
| 28 | G4AblaFission and G4AblaFissionSimfis18 translation units to make them |
|---|
| 29 | self-consistent. |
|---|
| 30 | |
|---|
| 31 | 24 October 2008 - Dennis Wright (hadr-incl-V09-01-03) |
|---|
| 32 | ----------------------------------------------------- |
|---|
| 33 | - use GetNuclearMass() instead of GetAtomicMass() in G4AblaEvaporation.cc |
|---|
| 34 | |
|---|
| 35 | 12 September 2008 - Pekka Kaitaniemi (hadr-incl-V09-01-02) |
|---|
| 36 | ------------------------------------ |
|---|
| 37 | - Bug fixes in INCL cascade: |
|---|
| 38 | o Fixed target nucleus initialization for targets with A >= 0.19 and |
|---|
| 39 | A <= 28. |
|---|
| 40 | o Fixed target nucleus radius calculation for targets 6 <= A < 19. |
|---|
| 41 | o Fixed conditional statements to avoid uninitialized variables. |
|---|
| 42 | o Several array index handling (off-by-one) bugs fixed. |
|---|
| 43 | o Several possible double/integer datatype problems fixed. |
|---|
| 44 | |
|---|
| 45 | 25 June 2008 - Pekka Kaitaniemi (hadr-incl-V09-01-01) |
|---|
| 46 | ------------------------------ |
|---|
| 47 | - Portability fixes and code clean-up: |
|---|
| 48 | o Removed all assert() calls. |
|---|
| 49 | o Removed all isnan() and isinf() calls. |
|---|
| 50 | o All math functions now use std:: namespace. |
|---|
| 51 | o Silenced the fission models. |
|---|
| 52 | |
|---|
| 53 | 26 May 2008 - Pekka Kaitaniemi (hadr-incl-V09-01-00) |
|---|
| 54 | ------------------------------ |
|---|
| 55 | - Bug fixes: |
|---|
| 56 | o Fixed serious data reading bug affecting the reading of data |
|---|
| 57 | files: flalpha.dat, frldm.dat and vgsld.dat. |
|---|
| 58 | - Fission reorganization: |
|---|
| 59 | o Two fission models are provided. By default GSI SimFis3 fission is |
|---|
| 60 | used. Optional SimFis18 is provided. |
|---|
| 61 | |
|---|
| 62 | 22 April 2008 - Pekka Kaitaniemi |
|---|
| 63 | ----------------------------------- |
|---|
| 64 | - INCL/ABLA changes: |
|---|
| 65 | o Fix: Partial fix to the Alpha evaporation energies. |
|---|
| 66 | o Fix: Neutron energies. |
|---|
| 67 | o Fix: Moved remnant direction calculation block and added safeguards. |
|---|
| 68 | o ABLA bugfix: switched the transformation matrix indices. |
|---|
| 69 | |
|---|
| 70 | 27 February 2008 - Pekka Kaitaniemi |
|---|
| 71 | ----------------------------------- |
|---|
| 72 | - INCL/ABLA changes since Geant4 9.1: |
|---|
| 73 | o Initialized variables to zero and improved coding style. |
|---|
| 74 | o Variable "bet" needs to be part of G4Fiss. |
|---|
| 75 | o Fixed a variable definition. Variable "homega" is part of "G4Fiss". |
|---|
| 76 | o Fixed an index off-by-one bug in G4Abla. |
|---|
| 77 | o Fix an infinite loop. |
|---|
| 78 | o Move the stored event number to the class definition. |
|---|
| 79 | o Added a possible (commented) fix for ABLA output off-by-one problem. |
|---|
| 80 | o Cleaned up G4Abla::qrot comments. |
|---|
| 81 | - Changes to the test suite since Geant4 9.1: |
|---|
| 82 | o Added more tests. |
|---|
| 83 | o New test system. |
|---|
| 84 | o Compare FORTRAN and C++ results. |
|---|
| 85 | o Preliminary GUI for running plotting scripts. |
|---|
| 86 | |
|---|
| 87 | 04 December 2007 - Gabriele Cosmo (hadr-incl-V09-00-09) |
|---|
| 88 | --------------------------------- |
|---|
| 89 | - Again commented out call to isnan() in G4Incl.cc for allow |
|---|
| 90 | porting to platforms other than Linux.... |
|---|
| 91 | |
|---|
| 92 | 03 December 2007 - Pekka Kaitaniemi |
|---|
| 93 | ----------------------------------- |
|---|
| 94 | - Added bugfixes to INCL nucleon array handling. Several off-by-one |
|---|
| 95 | bugs were fixed. These fixes help with INCL neutron energy spectra. |
|---|
| 96 | - 4-momentum conservation problem was noticed to be mainly ABLA |
|---|
| 97 | related. |
|---|
| 98 | o INCL alone violates energy conservation only by less than 20 MeV. |
|---|
| 99 | o ABLA has problems with baryon number conservation. Some produced |
|---|
| 100 | nucleons are not given back to INCL and Geant4. This is probably the |
|---|
| 101 | main reason for 4-momentum conservation violations. |
|---|
| 102 | - Added 4-momentum and baryon number conservation checking code to the |
|---|
| 103 | interfaces (behind flag DEBUGINCL). |
|---|
| 104 | |
|---|
| 105 | 15 November 2007 - Pekka Kaitaniemi |
|---|
| 106 | ----------------------------------- |
|---|
| 107 | - First fix to secondary particle Pt, Px and Phi distributions. |
|---|
| 108 | o Momentum x-component was transformed incorrectly from spherical to |
|---|
| 109 | cartesian coordinates. |
|---|
| 110 | |
|---|
| 111 | 08 November 2007 - Pekka Kaitaniemi |
|---|
| 112 | ----------------------------------- |
|---|
| 113 | - Started using G4UniformRand as a random number generator. |
|---|
| 114 | o It is much more sophisticated generator than the original INCL one |
|---|
| 115 | was. |
|---|
| 116 | o This should eliminate infinite loop in test runs on 64-bit |
|---|
| 117 | plattforms. The old generator probably was not 64-bit clean. |
|---|
| 118 | |
|---|
| 119 | 31 October 2007 - Gabriele Cosmo (hadr-incl-V09-00-05) |
|---|
| 120 | -------------------------------- |
|---|
| 121 | - Again commented out calls to isnan() and isinf() in G4Abla.cc for allow |
|---|
| 122 | porting to platforms other than Linux. |
|---|
| 123 | |
|---|
| 124 | 30 October 2007 - Pekka Kaitaniemi |
|---|
| 125 | ---------------------------------- |
|---|
| 126 | - Abla now runs. Integrated energy spectrums for protons and neutrons |
|---|
| 127 | seem to be OK. Isotope production is still problematic. There seems |
|---|
| 128 | to be too much fission. |
|---|
| 129 | |
|---|
| 130 | 24 October 2007 - Pekka Kaitaniemi (hadr-incl-V09-00-04) |
|---|
| 131 | ---------------------------------- |
|---|
| 132 | - Modified INCL to filter out unphysical events containing particles |
|---|
| 133 | that have more energy than the energy of the projectile. This should |
|---|
| 134 | fix problem we had with outcoming neutrons (and protons) that have |
|---|
| 135 | more energy than the projectile particle. |
|---|
| 136 | - Added G4InclAblaDataFile class that reads data used by INCL/ABLA |
|---|
| 137 | from datafiles located in $G4ABLADATA. If this environment variable |
|---|
| 138 | is not correctly set INCL/ABLA returns G4Exception. |
|---|
| 139 | - Problematic hardcoded data has been removed. |
|---|
| 140 | |
|---|
| 141 | 16 October 2007 - Pekka Kaitaniemi |
|---|
| 142 | ------------------------------------------------------ |
|---|
| 143 | - Silenced the rather verbose output. Now nothing should be printed on |
|---|
| 144 | terminal by default. |
|---|
| 145 | - Fixed INCL internal random number generator bug that sometimes |
|---|
| 146 | (rarely) produced random numbers that were greater than 1.0. |
|---|
| 147 | - Random number seeds are now taken from CLHEP::HepRandom. |
|---|
| 148 | - Cleaned up some commented code. |
|---|
| 149 | - Found new NaN bugs in ABLA. |
|---|
| 150 | |
|---|
| 151 | 13 October 2007 - Pekka Kaitaniemi |
|---|
| 152 | ------------------------------------------------------ |
|---|
| 153 | - Interface cleanup. G4InclCascadeInterface and |
|---|
| 154 | G4InclLightIonInterface should be fully operational. |
|---|
| 155 | - INCL was reverted back to using simple random number generator for |
|---|
| 156 | test result compatibility (to produce exactly same results as the |
|---|
| 157 | FORTRAN version does). |
|---|
| 158 | - Fixes for ABLA evaporation/fission: |
|---|
| 159 | o Fission barrier problem fixed. Now fission code is called during |
|---|
| 160 | the run. |
|---|
| 161 | o Several NaN bugs fixed. |
|---|
| 162 | o Random seed initialization bug fixed. |
|---|
| 163 | o Stand-alone INCL/ABLA program (test/standaloneinclabla) mostly |
|---|
| 164 | works (produces results that are sometimes in good agreement with |
|---|
| 165 | FORTRAN version and sometimes in not so good agreement). With |
|---|
| 166 | heavy targets and lots of energy fission is overestimated. |
|---|
| 167 | o INCL+ABLA interface not yet fully operational. G4 simulation run |
|---|
| 168 | crashes. |
|---|
| 169 | |
|---|
| 170 | 11 October 2007 - Gabriele Cosmo (hadr-incl-V09-00-01) |
|---|
| 171 | ------------------------------------------------------ |
|---|
| 172 | - Fixes for porting: |
|---|
| 173 | o Commented out usage of isnan() and isinf() in assertions. |
|---|
| 174 | o Replaced usage of M_PI with CLHEP::pi. |
|---|
| 175 | o Use std namespace for standard mathematical functions. |
|---|
| 176 | o Casted to double arguments used in std::pow() function. |
|---|
| 177 | o Commented out initialisation of data in G4InclAblaHardcodedData.cc |
|---|
| 178 | for Windows; temporary solution to allow for compilation, pending |
|---|
| 179 | solution of loading of data from file ! |
|---|
| 180 | |
|---|
| 181 | 23 May 2007 - Aatos Heikkinen (hadr-incl-V09-00-00) |
|---|
| 182 | --------------------------------------------------- |
|---|
| 183 | - First version of the Liege cascade INCL Model. |
|---|
| 184 | |
|---|
| 185 | |
|---|
