Changeset 846 for trunk/source/visualization/management

Timestamp:

Jun 27, 2008, 3:37:41 PM (17 years ago)

Author:

garnier

Message:

last updates

Location:

trunk/source/visualization/management

Files:

• History (modified) (2 diffs)
• include/G4ViewParameters.hh (modified) (2 diffs)
• src/G4ViewParameters.cc (modified) (2 diffs)
• src/G4VisCommandsScene.cc (modified) (2 diffs)
• src/G4VisCommandsViewer.cc (modified) (4 diffs)

trunk/source/visualization/management/History

@@ -1 @@
-$Id: History,v 1.107 2008/03/10 16:23:42 lgarnier Exp $
+$Id: History,v 1.110 2008/04/30 10:07:28 allison Exp $
 
 -------------------------------------------------------------------
@@ -26 +26 @@
 History file for visualization management sub-category
 ------------------------------------------------------
+
+30th April 2008  John Allison  (visman-V09-01-04)
+- Fixes more gcc-4.3.0 compiler warnings.
+
+28th April 2008  John Allison  (visman-V09-01-03)
+- G4VisCommandsScene.cc: Improve warning message.
+- G4ViewParameters.hh: Improve commenting for Software Ref. Man.
+
+4th April 2008  John Allison  (visman-V09-01-02)
+ - Fixed gcc-4.3.0 compiler warnings.
 
 5th February 2008, Laurent Garnier

trunk/source/visualization/management/include/G4ViewParameters.hh

@@ -25 +25 @@
 //
 //
-// $Id: G4ViewParameters.hh,v 1.27 2008/03/10 16:23:42 lgarnier Exp $
+// $Id: G4ViewParameters.hh,v 1.28 2008/04/28 16:14:12 allison Exp $
 // GEANT4 tag $Name:  $
 //
@@ -210 +210 @@
   void SetLightsMoveWithCamera (G4bool moves);
   void SetPan                  (G4double right, G4double up);
-  /** Increment currentTarget point by following X,Y values
-   */
   void IncrementPan            (G4double right, G4double up);
-  /** Increment currentTarget point by following X,Y,Z values
-   */
-  void IncrementPan            (G4double right, G4double up, G4double distance);
+  // Increment currentTarget point perpendicular to viewpoint direction.
+  void IncrementPan            (G4double right, G4double up, G4double forward);
+  // Increment currentTarget point also along viewpoint direction.
   void SetDefaultVisAttributes (const G4VisAttributes&);
   void SetDefaultTextVisAttributes (const G4VisAttributes&);

trunk/source/visualization/management/src/G4ViewParameters.cc

@@ -25 +25 @@
 //
 //
-// $Id: G4ViewParameters.cc,v 1.30 2008/03/10 16:23:42 lgarnier Exp $
+// $Id: G4ViewParameters.cc,v 1.31 2008/04/04 13:48:53 allison Exp $
 // GEANT4 tag $Name:  $
 //
@@ -513 +513 @@
 
   if (IsExplode() &&
-      (fExplodeFactor != v.fExplodeFactor) ||
-      (fExplodeCentre != v.fExplodeCentre)) return true;
+      ((fExplodeFactor != v.fExplodeFactor) ||
+       (fExplodeCentre != v.fExplodeCentre))) return true;
 
   return false;

trunk/source/visualization/management/src/G4VisCommandsScene.cc

@@ -25 +25 @@
 //
 //
-// $Id: G4VisCommandsScene.cc,v 1.67 2007/11/10 15:03:56 allison Exp $
+// $Id: G4VisCommandsScene.cc,v 1.68 2008/04/28 16:12:38 allison Exp $
 // GEANT4 tag $Name:  $
 
@@ -244 +244 @@
       G4cout << " events.";
       if (maxNumberOfKeptEvents > 1 || maxNumberOfKeptEvents < 0)
-        G4cout << "\n  This may use a lot of memory.";
+        G4cout <<
+          "\n  This may use a lot of memory."
+          "\n  It may be changed with, e.g., "
+          "\"/vis/scene/endOfEventAction accumulate 10\".";
     }
     G4cout << G4endl;

trunk/source/visualization/management/src/G4VisCommandsViewer.cc

@@ -25 +25 @@
 //
 //
-// $Id: G4VisCommandsViewer.cc,v 1.68 2007/01/11 16:41:30 allison Exp $
+// $Id: G4VisCommandsViewer.cc,v 1.70 2008/04/30 10:07:28 allison Exp $
 // GEANT4 tag $Name:  $
 
@@ -405 +405 @@
   // blanks within quotation marks...
   char c;
-  while (is.get(c) && c == ' ');
+  while (is.get(c) && c == ' '){}
   if (c == '"') {
-    while (is.get(c) && c != '"') originalName += c;
+    while (is.get(c) && c != '"') {originalName += c;}
   }
   else {
     originalName += c;
-    while (is.get(c) && c != ' ') originalName += c;
+    while (is.get(c) && c != ' ') {originalName += c;}
   }
   originalName = originalName.strip (G4String::both, ' ');
@@ -427 +427 @@
   originalName = originalViewer->GetName();  // Ensures long name.
 
-  while (is.get(c) && c == ' ');
+  while (is.get(c) && c == ' '){}
   if (c == '"') {
-    while (is.get(c) && c != '"') cloneName += c;
+    while (is.get(c) && c != '"') {cloneName += c;}
   }
   else {
     cloneName += c;
-    while (is.get(c) && c != ' ') cloneName += c;
+    while (is.get(c) && c != ' ') {cloneName += c;}
   }
   cloneName = cloneName.strip (G4String::both, ' ');
@@ -564 +564 @@
   // contains embedded blanks within quotation marks...
   char c;
-  while (is.get(c) && c == ' ');
+  while (is.get(c) && c == ' '){}
   if (c == '"') {
-    while (is.get(c) && c != '"') newName += c;
+    while (is.get(c) && c != '"') {newName += c;}
   }
   else {
     newName += c;
-    while (is.get(c) && c != ' ') newName += c;
+    while (is.get(c) && c != ' ') {newName += c;}
   }
   newName = newName.strip (G4String::both, ' ');